fix: service account for cleanup runtime resources #642
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/e2e |
|
@ATGardner @scme0 Would you mind looking into why the CI workflow didn't succeed? I really appreciate it in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request makes a minor update to the
cleanup-resources.yamlhook template by changing theserviceAccountused for the cleanup job. The new service account,runtime-cleanup, is likely more appropriate for the job's permissions and responsibilities.serviceAccountin thecharts/gitops-runtime/templates/hooks/pre-uninstall/cleanup-resources.yamlfile fromargocd-application-controllertoruntime-cleanupto better align with the job's purpose.Why
Notes
Use case: leveraging the
gitops-runtimechart for the deployment ofargo-rolloutscomponents within Managed Clusters. In this context, I disable nearly all Codefresh GitOps Runtime components in thevalues.yaml(including the argo-cd dependency, which is the reason the Argo Application Controller is absent) to focus exclusively on theargo-rolloutscomponents (Argo Rollouts and its Event Reporter) on Managed Clusters connected to the Runtime.